Replace makeStyles with styled in ReportComplete for MUI v5 compatibi… #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity This commit transitions the ReportComplete component styling approach from using makeStyles to the styled API provided by Material-UI v5. The change is part of an effort to align with the latest best practices and features offered by Material-UI, ensuring greater consistency and ease of theme integration across the project.
aqeelat
reviewed
Jan 22, 2025
| <Collapse in={expanded} timeout="auto" unmountOnExit> | ||
| <Paper className={classes.paper}> | ||
| <StyledPaper> |
There was a problem hiding this comment.
Suggested change
| <StyledPaper> | |
| <Paper sx={{ bgColor: '#fff', p: 2 }}> |
I think it is better to use sx prop instead of a styled component so that it can be easier to sync with the theme. ( I think even the background color should some from the theme as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit transitions the ReportComplete component styling approach from using makeStyles to the styled API provided by Material-UI v5. The change is part of an effort to align with the latest best practices and features offered by Material-UI, ensuring greater consistency and ease of theme integration across the project.