Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bengali (Bangladesh) [bn-bd] locale #1806

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

shahibuzzaman
Copy link
Contributor

@shahibuzzaman shahibuzzaman commented Feb 12, 2022

bn-bd locale is for Bangladesh.

ref : https://github.com/moment/moment/blob/develop/locale/bn-bd.js

@iamkun Could you please review this PR?

@shahibuzzaman shahibuzzaman changed the title add Bengali (Bangladesh) [bn-bd] local add Bengali (Bangladesh) [bn-bd] locale Feb 12, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1806 (b4b35a2) into dev (32b7fe3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1806   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       181    +1     
  Lines         2034      2057   +23     
  Branches       524       537   +13     
=========================================
+ Hits          2034      2057   +23     
Impacted Files Coverage Δ
src/locale/bn-bd.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b7fe3...b4b35a2. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Mar 11, 2022

LGTM, could you please add some unit test, please

@iamkun
Copy link
Owner

iamkun commented Mar 11, 2022

image
also please fix these lint errors, cheers

@iamkun iamkun merged commit 840ed76 into iamkun:dev Apr 14, 2022
iamkun pushed a commit that referenced this pull request Apr 15, 2022
## [1.11.1](v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](#1806)) ([840ed76](840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](#1836)) ([627fa39](627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](#1831)) ([4e2802c](4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](#1829)) ([8e6d11d](8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](#1848)) ([a597d0b](a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](#1823)) ([e790516](e790516))
@iamkun
Copy link
Owner

iamkun commented Apr 15, 2022

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants