Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript definition to correctly reflect the usage #466

Closed
wants to merge 2 commits into from

Conversation

wangyiz4262
Copy link
Contributor

Type definition files should only contain interfaces or types.

Besides, dayjs should be imported as import dayjs from 'dayjs';, instead of import * as dayjs from 'dayjs', which means namespace is not necessary.

@codecov-io
Copy link

codecov-io commented Jan 27, 2019

Codecov Report

Merging #466 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #466   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        53     53           
  Lines       470    470           
  Branches     72     72           
===================================
  Hits        470    470

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4517a8...a88f2f8. Read the comment docs.

@wangyiz4262 wangyiz4262 changed the title Fix typings to correctly reflect the usage Fix Typescript type definition to correctly reflect the usage Jan 27, 2019
@wangyiz4262 wangyiz4262 changed the title Fix Typescript type definition to correctly reflect the usage Fix Typescript definition to correctly reflect the usage Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants