D2M #476
Merged
D2M #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 56 56
Lines 497 496 -1
Branches 80 80
=====================================
- Hits 497 496 -1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.8.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anka-213
reviewed
Feb 11, 2020
Comment on lines
+1
to
3
| export = dayjs; | ||
| declare function dayjs (config?: dayjs.ConfigType, option?: dayjs.OptionType): dayjs.Dayjs | ||
| export default dayjs | ||
|
|
There was a problem hiding this comment.
Why was this reverted? Importing it as import * as dayjs from 'dayjs' doesn't seem to work. What is the correct way to import this from typescript?
There was a problem hiding this comment.
you can check https://day.js.org/docs/en/installation/typescript for installation guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.