Feature: Relative time for fusional languages #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or past prop as a fn for relative time
Codecov Report
@@ Coverage Diff @@
## dev #659 +/- ##
==========================================
- Coverage 99.89% 99.43% -0.47%
==========================================
Files 154 154
Lines 989 1055 +66
Branches 148 176 +28
==========================================
+ Hits 988 1049 +61
- Misses 1 5 +4
- Partials 0 1 +1
Continue to review full report at Codecov.
|
|
Thanks, but here's a simple one. #767 |
|
Polish seems to be not handled in #767. |
|
@iamkun how to know when / whether this fix is available in release (and which version)? |
|
next coming version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently there are several issues regarding relative time on fusional languages, this PR would address these issues (I hope I didn't miss any):
#610 #416 #415 #302
I have looked through moment implementation of relative time and adapted it to fit dayjs. I am aware that a lot of the this code is taken from moment, but I don't think that reinventing the wheel in this place is a good approach. I think it is okay to have moment as a point of truth for proper localization results, because translation is a very long process and this makes it easy to have correct translations even without knowing the language.
There are a couple of fixes in language translations (polish for example was completely off, since translating relative time to the past translates it as a future term, see "po 1 godziny" for example.).
I have also added preparsers/postparsers when needed. In this case Arabic locale numerals.
I've added tests and some helpers to reduce code duplication and add coverage to localized formats. Current implementation makes it easy to compare dayjs localization results with moment. There are some cases that are difficult to cover, so I'm leaving it not as 100% for now.
I've also added handling for relative time formats as functions, which addresses plural forms in most cases.
Thanks in advance for taking a moment (no pun intended) to look into this and please voice any concerns that you may have.