Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add plugin objectSupport #887

Merged
merged 14 commits into from
Apr 30, 2020
84 changes: 84 additions & 0 deletions src/plugin/objectSupport/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
export default (o, c) => {
const proto = c.prototype
const isObject = obj => !(obj instanceof Date) && !(obj instanceof Array) && obj instanceof Object
const prettyUnit = (u) => {
const unit = proto.$utils().p(u)
return unit === 'date' ? 'day' : unit
}
const parseDate = (cfg) => {
const { date, utc } = cfg
const $d = {}
if (isObject(date)) {
Object.keys(date).forEach((k) => {
$d[prettyUnit(k)] = date[k]
})
const arr = [
$d.year || 1970,
$d.month - 1 || 0,
$d.day || 1,
$d.hour || 0,
$d.minute || 0,
$d.second || 0,
$d.millisecond || 0
]
if (utc) return new Date(Date.UTC(...arr))
return new Date(...arr)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid using this ...arr advanced es6 syntax, this will hugely increase the bundle size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems much smaller now in packed

}
return date
}

const oldParse = proto.parse
proto.parse = function (cfg) {
// console.log(cfg)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test code, pls.

cfg.date = parseDate.bind(this)(cfg)
oldParse.bind(this)(cfg)
}

const setObject = function (argument) {
const keys = Object.keys(argument)
let chain = this.clone()
keys.forEach((key) => {
chain = chain.$set(key, argument[key])
})
return chain
}
const addObject = function (argument) {
const keys = Object.keys(argument)
let chain = this
keys.forEach((key) => {
chain = chain.add(argument[key], key)
})
return chain
}

const subtractObject = function (argument) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these three functions could be combined into one function with different arguments

const keys = Object.keys(argument)
let chain = this
keys.forEach((key) => {
chain = chain.subtract(argument[key], key)
})
return chain
}

const oldSet = proto.set
proto.set = function (string, int) {
if (string instanceof Object) {
return setObject.bind(this)(string)
}
return oldSet.bind(this)(string, int)
}
const oldAdd = proto.add
proto.add = function (number, string) {
if (number instanceof Object) {
return addObject.bind(this)(number)
}
return oldAdd.bind(this)(number, string)
}
const oldSubtract = proto.subtract
proto.subtract = function (number, string) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

substract could be implemented as negative add, subtract { day: 1 } => add { day: 1 * -1 }, so that we could only care add and set logic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the three methods have been merged into one.

if (number instanceof Object) {
return subtractObject.bind(this)(number)
}
return oldSubtract.bind(this)(number, string)
}
}
Loading