Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issue #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build issue #1

wants to merge 1 commit into from

Conversation

AndrewJack
Copy link

ExoPlayer uses the newer version of the support library than react native which caused this duplicate entry error

./gradlew app:dependencies shows the version react native and exoplayer uses

compile - Classpath for compiling the main sources.
+--- project :react-native-video-exoplayer
|    +--- com.google.android.exoplayer:exoplayer:r2.4.0
|    |    +--- com.google.android.exoplayer:exoplayer-core:r2.4.0
|    |    |    \--- com.android.support:support-annotations:25.3.1
|    |    +--- com.google.android.exoplayer:exoplayer-dash:r2.4.0
|    |    |    +--- com.google.android.exoplayer:exoplayer-core:r2.4.0 (*)
|    |    |    +--- com.android.support:support-annotations:25.3.1
|    |    |    \--- com.android.support:support-core-utils:25.3.1
|    |    |         +--- com.android.support:support-annotations:25.3.1
|    |    |         \--- com.android.support:support-compat:25.3.1
|    |    |              \--- com.android.support:support-annotations:25.3.1
|    |    +--- com.google.android.exoplayer:exoplayer-hls:r2.4.0
|    |    |    +--- com.google.android.exoplayer:exoplayer-core:r2.4.0 (*)
|    |    |    \--- com.android.support:support-annotations:25.3.1
|    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:r2.4.0
|    |    |    +--- com.google.android.exoplayer:exoplayer-core:r2.4.0 (*)
|    |    |    \--- com.android.support:support-annotations:25.3.1
|    |    \--- com.google.android.exoplayer:exoplayer-ui:r2.4.0
|    |         +--- com.google.android.exoplayer:exoplayer-core:r2.4.0 (*)
|    |         \--- com.android.support:support-annotations:25.3.1
|    +--- com.google.android.exoplayer:extension-okhttp:r2.4.0
|    |    \--- com.google.android.exoplayer:exoplayer-core:r2.4.0 (*)
|    \--- com.squareup.okhttp3:okhttp:3.4.2 -> 3.6.0
|         \--- com.squareup.okio:okio:1.11.0 -> 1.13.0
\--- com.facebook.react:react-native:+ -> 0.46.2
     +--- javax.inject:javax.inject:1
     +--- com.android.support:appcompat-v7:23.0.1
     |    \--- com.android.support:support-v4:23.0.1
     |         \--- com.android.support:support-annotations:23.0.1 -> 25.3.1
     +--- com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0
     |    \--- com.facebook.fbui.textlayoutbuilder:staticlayout-proxy:1.0
     +--- com.facebook.fresco:fresco:1.0.1
     |    +--- com.facebook.fresco:drawee:1.0.1
     |    |    \--- com.facebook.fresco:fbcore:1.0.1
     |    +--- com.facebook.fresco:fbcore:1.0.1
     |    \--- com.facebook.fresco:imagepipeline:1.0.1
     |         +--- com.parse.bolts:bolts-tasks:1.4.0
     |         +--- com.facebook.fresco:fbcore:1.0.1
     |         \--- com.facebook.fresco:imagepipeline-base:1.0.1
     |              +--- com.parse.bolts:bolts-tasks:1.4.0
     |              \--- com.facebook.fresco:fbcore:1.0.1
     +--- com.facebook.fresco:imagepipeline-okhttp3:1.0.1
     |    +--- com.squareup.okhttp3:okhttp:3.0.1 -> 3.6.0 (*)
     |    +--- com.facebook.fresco:fbcore:1.0.1
     |    \--- com.facebook.fresco:imagepipeline:1.0.1 (*)
     +--- com.facebook.soloader:soloader:0.1.0
     +--- com.google.code.findbugs:jsr305:3.0.0
     +--- com.squareup.okhttp3:okhttp:3.6.0 (*)
     +--- com.squareup.okhttp3:okhttp-urlconnection:3.6.0
     |    \--- com.squareup.okhttp3:okhttp:3.6.0 (*)
     +--- com.squareup.okio:okio:1.13.0
     \--- org.webkit:android-jsc:r174650

AndrewJack
AndrewJack commented Jul 13, 2017
View reviewed changes
android/app/build.gradle
@@ -140,6 +140,7 @@ dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile project(':react-native-video-exoplayer')
compile "com.facebook.react:react-native:+" // From node_modules
compile "com.android.support:appcompat-v7:25.3.1"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forces react native to use the newer version.

AndrewJack
AndrewJack commented Jul 13, 2017
View reviewed changes
android/app/build.gradle
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion 25
buildToolsVersion "25.0.3"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must use with the same major version as the support library

@AndrewJack AndrewJack mentioned this pull request Jul 13, 2017
Closed
@areeb111
Copy link

Thank you this is helped me out

@AndrewJack AndrewJack mentioned this pull request Sep 13, 2017
Merged
This was referenced May 18, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewJack @areeb111