-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tablespace calculation #153
Comments
Thanks for your feedback! In fact, it could be a good idea to give this feedback. If you agree with that, we can then add a deprecation warning on the old metrics and then switch to the new one. Maybe we need to be able to select this by using tags or something similar. |
@Yannig as a more direct reply to your questions above, I'm okay with either approach (deprecation or tags). I can definitely prepare a PR according to whichever approach you think is best. |
I think we can use the tag approach and use them to switch easily between the different queries and use reserved word for the deprecation messages: if a request have a tag deprecated, we send a deprecation warning in the output. We can also add an option to disable this kind of warning. This way, we can handle tags easily and be able to disable deprecated request using tag filter. |
Alright, well, we've got a PR now: #154 |
Okay, #154 should be ready for merge. The already-existing tags will create the image with the default-metrics file including the new tablespace calculation, while the |
@Yannig how do you feel about the PR for this? Is there anything I can do to help push it along or make it easier to polish? |
Hi @neilschelly and happy new year! Sorry for the delay, I took to long to get you feedback about this PR ... To be honest, I had thought of a different approach but I realize that I don't have the time to do it. After all, your approach is simple and the merit of not adding any code. So if you are ok with that, I will merge it Regards, |
That would be much appreciated. If you'd like help trying to build some alternative approach, I am game for taking an attempt on that too if I can help. |
Fine. So let's merge you PR. I will try to comment this issue to explain myself on what I was thinking about. |
The Oracle DBAs at my org have requested a new query to use to track tablespace utilization. It has significantly different metrics for us, but they appear a lot more useful. This matches the numbers that are reported to them in the Oracle Enterprise Manager. The
dba_tablespace_usage_metrics
table should be available in Oracle 10g and up.Here's what's different for us:
undotbs1
andundotbs2
tablespace, with the second one at 0%. I'm told that second one will begin to show up indba_tablespace_usage_metrics
as soon as it's used, like when activating a second node or assigning it as an active undo_tablespace.I'm running both the old and new queries in parallel in our environments now for a week to compare, and I expect I'll switch over to the new one entirely. I can provide a better glimpse of how different it is then, but I suspect it won't be close (especially for tmp/undo/system tablespaces). I'd be happy to provide this as a PR to update the query used in default-metrics.conf, but I was hesitant to do it without knowing how to handle such a "breaking" change, where a lot of user thresholds based on the old calculation may be inappropriate on the new calculation.
The text was updated successfully, but these errors were encountered: