Canon MakerNote: Allow callable to process tag value #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on some images I found that the library did not expose the 'CameraTemperature' tag from the ShotInfo MakerNote. To support this I added a callable and allow that callable to be called with the tag value. I might be useful for other tags too. Example output from a JPEG image taken on a Canon EOS 2000D: ``` >>> exif = exifread.process_file(fd, details=True) >>> exif["MakerNote CameraTemperature"] (0x0000) Proprietary=55 C @ 0 ``` Signed-off-by: Daan van Gorkum <djvg@djvg.net>
|
I don't think the test failures are related to my changes but let me know if they are and happy to amend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some images I found that the library did not expose the 'CameraTemperature' tag from the ShotInfo MakerNote.
To support this I added a callable and allow that callable to be called with the tag value. I might be useful for other tags too.
Example output from a JPEG image taken on a Canon EOS 2000D: