Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBActionSheet doesn't grey out status bar #10

Open
samlester opened this issue Feb 23, 2014 · 10 comments
Open

IBActionSheet doesn't grey out status bar #10

samlester opened this issue Feb 23, 2014 · 10 comments

Comments

@samlester
Copy link

We're using this framework for a project and I've just noticed that the status bar isn't greyed out when using the IBActionSheet. It's particularly noticeable when it's set to be white.

Is this just a limitation of the system or can it be fixed?

Thanks!

@ianb821
Copy link
Owner

ianb821 commented Feb 23, 2014

Awesome, glad to hear it's being used. What version are you targeting with your project, and are you using a UINavigationController?

On Sat, Feb 22, 2014 at 8:39 PM, Sam Lester notifications@github.com
wrote:

We're using this framework for a project and I've just noticed that the status bar isn't greyed out when using the IBActionSheet. It's particularly noticeable when it's set to be white.
Is this just a limitation of the system or can it be fixed?

Thanks!

Reply to this email directly or view it on GitHub:
#10

@samlester
Copy link
Author

We're targeting iOS7 and using a UINavigationController.

@ianb821
Copy link
Owner

ianb821 commented Feb 23, 2014

Okay, when you're calling showInView are you doing it like this:

[actionSheet showInView:self.navigationController.view];

or are you just doing:

[actionSheet showInView:view];

@samlester
Copy link
Author

The first one.

@samlester
Copy link
Author

It looks like it's doing the same in the example project – it's just more difficult to tell because the status bar is black to start with. When the phone is plugged in the green battery icon isn't dimmed out.

@ianb821
Copy link
Owner

ianb821 commented Feb 23, 2014

That's odd, I'm using it in a project with the same setup and it dims it. Try changing line 508 of IBActionSheet to self.transparentView.alpha = 1.0; And then seeing if it's blacking it out or not.

On Sat, Feb 22, 2014 at 9:30 PM, Sam Lester notifications@github.com
wrote:

The first one.

Reply to this email directly or view it on GitHub:
#10 (comment)

@samlester
Copy link
Author

It's still not working. For testing we've changed the status bar on the example app to white so we can see the issue better. Here's what we're seeing:

photo 23-02-2014 03 37 33
photo 23-02-2014 03 37 29

@ianb821
Copy link
Owner

ianb821 commented Feb 23, 2014

Yeah, that definitely doesn't look dimmed out. I'm honestly not sure, I've never run into it. I'll have to dig around and see what I can come up with.

On Sat, Feb 22, 2014 at 9:40 PM, Sam Lester notifications@github.com
wrote:

It's still not working. For testing we've changed the status bar on the example app to white so we can see the issue better. Here's what we're seeing:
photo 23-02-2014 03 37 33

photo 23-02-2014 03 37 29

Reply to this email directly or view it on GitHub:
#10 (comment)

@samlester
Copy link
Author

Ok, cool – no rush on our end, it's only a small issue and won't stop us from using it in production. Drop me a line if you find something.

@ianb821
Copy link
Owner

ianb821 commented Feb 23, 2014

Will do, thanks for letting me know about the issue.

On Sat, Feb 22, 2014 at 9:45 PM, Sam Lester notifications@github.com
wrote:

Ok, cool – no rush on our end, it's only a small issue and won't stop us from using it in production. Drop me a line if you find something.

Reply to this email directly or view it on GitHub:
#10 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants