Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment packaging task #38

Merged
merged 1 commit into from
Jan 22, 2015
Merged

Add deployment packaging task #38

merged 1 commit into from
Jan 22, 2015

Conversation

ianks
Copy link
Owner

@ianks ianks commented Jan 16, 2015

Thanks to @FooBarWidget for showing me the way of the Traveling Ruby.

As of now the logic for building the packages is there. However, there are a few outstanding issues.

  1. I have not tested the builds on Linux yet.
  2. I have not decided on how/where to store the builds.
    • I want to have a history of all the builds for each version, so something like S3 sounds good for that. However, I want people to be able to install the HEAD from Github if they want to in Homebrew (eventually). This leads me to believe we might want to have some CI hook which maintains that. Although the trouble/value ratio on that might not be in my favor.

Please comment with any ideas/refactoring you see. Thanks!

@ianks ianks force-pushed the package branch 4 times, most recently from e1be624 to 998c598 Compare January 16, 2015 06:09
@ianks ianks mentioned this pull request Jan 16, 2015
@FooBarWidget
Copy link
Contributor

Can't you host the builds on Github releases? Don't they support file attachments nowadays?

As for the Homebrew HEAD version: you can have the Homebrew recipe make a Traveling Ruby package.

@ianks
Copy link
Owner Author

ianks commented Jan 16, 2015

@FooBarWidget Yeah I think I might end up doing with Github releases now that you mention it.

As for building the Traveling Ruby Package from HEAD, in the docs you mention there is a requirement for 2.1.x for bundle installing the Gems as that is what TR uses. Doesn't that kind of rule out building the package from HEAD?

@FooBarWidget
Copy link
Contributor

That's right. But in your Homebrew recipe you could simply download Traveling Ruby and use that to run bundle install.

ianks added a commit that referenced this pull request Jan 22, 2015
Add deployment packaging task
@ianks ianks merged commit 197a145 into master Jan 22, 2015
@ianks ianks removed the in progress label Jan 22, 2015
@ianks ianks deleted the package branch January 22, 2015 03:52
@FooBarWidget
Copy link
Contributor

I think "Distrubution" should be "Distribution".

@ianks
Copy link
Owner Author

ianks commented Jan 22, 2015

Thanks @FooBarWidget

#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants