Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Support userAgent specified in testEnvironmentOptions #4

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Support userAgent specified in testEnvironmentOptions #4

merged 2 commits into from
Nov 28, 2019

Conversation

diegohaz
Copy link
Contributor

Closes #3

@ianschmitz
Copy link
Owner

Hi @diegohaz - thanks for the PR. Have you confirmed that this change fixes the issue as described in #3?

@ianschmitz ianschmitz added bug Something isn't working PR: Bug Fix 🐛 and removed bug Something isn't working labels Nov 28, 2019
@diegohaz
Copy link
Contributor Author

@ianschmitz Yes! I'm currently using patch-package with these changes to make it work.

@ianschmitz ianschmitz changed the title Support userAgent on jestEnvironmentOptions Support Jest testEnvironmentOptions Nov 28, 2019
@ianschmitz ianschmitz changed the title Support Jest testEnvironmentOptions Support userAgent specified in Jest testEnvironmentOptions Nov 28, 2019
@ianschmitz ianschmitz changed the title Support userAgent specified in Jest testEnvironmentOptions Support userAgent specified in testEnvironmentOptions Nov 28, 2019
@ianschmitz ianschmitz merged commit 481f132 into ianschmitz:master Nov 28, 2019
@ianschmitz
Copy link
Owner

Great. Thanks for the fix! I'll add tests in a follow-up PR and release shortly.

ianschmitz added a commit that referenced this pull request Nov 28, 2019
@ianschmitz
Add tests for #4
a27026a
@ianschmitz
Copy link
Owner

Should be all fixed in 1.0.1.

ianschmitz added a commit to ianschmitz/jest-environment-jsdom-fourteen that referenced this pull request Nov 28, 2019
@ianschmitz
Port fix from ianschmitz/jest-environment-jsdom-fifteen#4
be76406
@diegohaz
Copy link
Contributor Author

Thanks! :)

@ianschmitz ianschmitz mentioned this pull request Nov 29, 2019
Closed
@lili2311 lili2311 mentioned this pull request Sep 26, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't pass userAgent to testEnvironmentOptions
2 participants
@diegohaz @ianschmitz