Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all instances of $page.url.pathname checks for tauri #45

Merged

Conversation

nikvdp
Copy link
Contributor

@nikvdp nikvdp commented Oct 4, 2024

basically in tauri $page.url.pathname gets set to "", but elsewhere it's "/", so account for that

this PR supersedes #44, that one can be closed if this PR is to be merged

basically in tauri $page.url.pathname gets set to "", but elsewhere it's
"/", so account for that
Copy link
Owner

@iansinnott iansinnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, thanks @nikvdp

@iansinnott iansinnott merged commit dad5d4a into iansinnott:master Oct 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants