Extracts history push to own function (#5382)

ianstormtaylor · Apr 3, 2023 · 42b60fb · 42b60fb
1 parent b52e08b
commit 42b60fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/slate-history/src/history-editor.ts b/packages/slate-history/src/history-editor.ts
@@ -17,6 +17,7 @@ export interface HistoryEditor extends BaseEditor {
   history: History
   undo: () => void
   redo: () => void
+  writeHistory: (stack: 'undos' | 'redos', batch: any) => void
 }
 
 // eslint-disable-next-line no-redeclare

diff --git a/packages/slate-history/src/with-history.ts b/packages/slate-history/src/with-history.ts
@@ -37,7 +37,7 @@ export const withHistory = <T extends Editor>(editor: T) => {
       })
 
       history.redos.pop()
-      history.undos.push(batch)
+      e.writeHistory('undos', batch)
     }
   }
 
@@ -61,7 +61,7 @@ export const withHistory = <T extends Editor>(editor: T) => {
         })
       })
 
-      history.redos.push(batch)
+      e.writeHistory('redos', batch)
       history.undos.pop()
     }
   }
@@ -97,7 +97,7 @@ export const withHistory = <T extends Editor>(editor: T) => {
           operations: [op],
           selectionBefore: e.selection,
         }
-        undos.push(batch)
+        e.writeHistory('undos', batch)
       }
 
       while (undos.length > 100) {
@@ -110,6 +110,10 @@ export const withHistory = <T extends Editor>(editor: T) => {
     apply(op)
   }
 
+  e.writeHistory = (stack: 'undos' | 'redos', batch: any) => {
+    e.history[stack].push(batch)
+  }
+
   return e
 }