Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IME] FF/macOS: entering accented letters from the Accent Menu inserts double character #982

Closed
danburzo opened this issue Aug 14, 2017 · 5 comments
Labels

Comments

@danburzo
Copy link
Contributor

danburzo commented Aug 14, 2017

Do you want to request a feature or report a bug?

There is a bug in Firefox/macOS with entering an accented letter from the Accent Menu (by holding down a key and pressing the keys 1 to N).

What's the current behavior?

At the subsequent key press (e.g. moving the caret with left/right arrow key), the non-accented character appears along with the accented one. See video here

What's the expected behavior?

A single, accented letter is inserted. Safari/Chrome work as expected.

Other RTEs

  • Draft.js exhibits the same problem
  • ProseMirror and Quill don't seem to have it
@danburzo danburzo changed the title macOS: entering accented letters from the Accent Menu inserts double character [IME] macOS: entering accented letters from the Accent Menu inserts double character Aug 14, 2017
@danburzo danburzo changed the title [IME] macOS: entering accented letters from the Accent Menu inserts double character [IME] FF/macOS: entering accented letters from the Accent Menu inserts double character Aug 16, 2017
@ianstormtaylor
Copy link
Owner

I believe this is fixed in the latest version of Slate.

@javierfernandes
Copy link

This is still happening for me in "slate": "^0.44.12",
But I'm also able to reproduce this in the current demo editor from https://www.slatejs.org/#/rich-text
slate-accent-menu-bug

Should this be reopened @ianstormtaylor ?

Thanks

@knubie
Copy link
Contributor

knubie commented Sep 28, 2019

This occurs in Chrome as well.

@achou11
Copy link

achou11 commented Oct 10, 2019

There's a PR for this that's looks ready to be merged: #3041

Will probably require a slate upgrade

@jens-lilt
Copy link

I can still see this occur in Slate 0.77.2 if I use the arrow keys to select the accent instead of typing the number shown underneath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants