Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slate-react] Pass renderEditor prop through into editor plugin #1899

Merged
merged 1 commit into from
Jun 15, 2018
Merged

[slate-react] Pass renderEditor prop through into editor plugin #1899

merged 1 commit into from
Jun 15, 2018

Conversation

davidchang
Copy link
Contributor

Is this adding or improving a feature or fixing a bug?

Fixing a bug

What's the new behavior?

Previously, the renderEditor prop was only applied when defined on a plugin, not when it was passed as a prop to the top-level Slate Editor component. Now, the renderEditor prop will be invoked.

How does this change work?

There was just a whitelist of plugin props that gets applied to the Editor component, renderEditor needed to be on the list

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn prettier.)
  • The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: #1841

@ianstormtaylor
Copy link
Owner

Good save, thanks @davidchang!

@ianstormtaylor ianstormtaylor merged commit 5eb04f3 into ianstormtaylor:master Jun 15, 2018
@davidchang davidchang deleted the 1841/persist-renderEditor-as-editor-plugin branch June 15, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renderEditor only works in plugin, not in Editor
2 participants