Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use-decorate because not work in some case(#4277) #4278

Closed
wants to merge 1 commit into from

Conversation

liangxiwei
Copy link
Contributor

Description
the useDecorate not work with editor's children
Issue
Fixes: (link to issue)
#4277

Example
no
Context
no
Checks
don't need?

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2021

⚠️ No Changeset found

Latest commit: c3d40ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@liangxiwei
Copy link
Contributor Author

liangxiwei commented May 21, 2021

I use some code to workaround with it.

function decorate(nodeEntry: NodeEntry): Range[] {
    let decorateRange: any[] = []
    const [node,] = nodeEntry
    if (Editor.isEditor(node)) {
        const editor = node
        const path = ReactEditor.findPath(editor, node)
        for (let i = 0; i < node.children.length; i++) {
            const p = path.concat(i)
            const n = node.children[i] as Descendant
            const ds = decorate([n, p])
            Array.prototype.push.apply(decorateRange, ds)
        }
        return decorateRange;
    } else {
        for (let plugin of plugins.values()) {
            if (plugin.decorate) {
                const ds = plugin.decorate(nodeEntry)
                Array.prototype.push.apply(decorateRange, ds)
            }
        }
    }
    return decorateRange
}
export { decorate }

@liangxiwei liangxiwei closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant