Don't show the placeholder when composing #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 359746d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Is this also addressing what's fixed in: #4246 |
I didn't notice the cursor suspension issue before. From the screen recording, I assume that it's also fixed. |
knubie
added a commit
to knubie/slate
that referenced
this pull request
Jul 12, 2021
dylans
approved these changes
Aug 4, 2021
This was referenced Aug 5, 2021
Merged
dylans
pushed a commit
to dylans/slate
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't show the placeholder when composing.
Issue
I found a related issue #4306 but it's closed. I think this issue should be handled inside the editable component because hiding placeholder when composing is an expected behavior.
Example
Old behavior:
old.behavior.mov
New behavior:
new.behavior.mov
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)