Fix reporting of marks on a markableVoid #5186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that
markableVoid()
allows marks to be applied to inline voids, our users discovered a problem where the marks applied to a currently-selected markable void are not reported properly byEditor.marks()
I have added a few unit tests for the previously un-tested
Editor.marks()
, including one for markable void that failed before the fix (markable-void-collapsed).The
if (anchor.offset === 0)
test inEditor.marks()
that checks if theprevPath
is in the same block was effectively returning the marks of any Text that preceded the selected markable void.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)