Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isHistory to match new interface. #5197

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

jacobcarpenter
Copy link
Contributor

Description
This change preserves the original functionality of isHistory, but does not add verification of History Batch's new selectionBefore property.

Issue
Fixes: #5177

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

This change merely preserves the original functionality and does not add verification of Batch's new `selectionBefore` property.
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: cfc6083

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-history Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@bryanph bryanph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me👍

@dylans dylans merged commit 70b64dc into ianstormtaylor:main Nov 17, 2022
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
@jacobcarpenter jacobcarpenter deleted the fix-isHistory branch November 17, 2022 18:20
z2devil pushed a commit to z2devil/slate that referenced this pull request Dec 6, 2024
* Update `isHistory` to match new interface.

This change merely preserves the original functionality and does not add verification of Batch's new `selectionBefore` property.

* Add changeset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History.isHistory/HistoryEditor.isHistoryEditor now incorrectly computed
3 participants