Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly paste ClipboardEvents in Safari #5362

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Directly paste ClipboardEvents in Safari #5362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f62033
Directly paste ClipboardEvents in Safari
jason0x43 Mar 15, 2023
ba02b2c
Add changeset
jason0x43 Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-papayas-hug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'slate-react': patch
---

Fix an issue where pastes in Safari wouldn't include application/x-slate-fragment data
6 changes: 5 additions & 1 deletion packages/slate-react/src/components/editable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,9 +1619,13 @@ export const Editable = (props: EditableProps) => {
// fall back to React's `onPaste` here instead.
// COMPAT: Firefox, Chrome and Safari don't emit `beforeinput` events
// when "paste without formatting" is used, so fallback. (2020/02/20)
// COMPAT: Safari InputEvents generated by pasting won't include
// application/x-slate-fragment items, so use the
// ClipboardEvent here. (2023/03/15)
if (
!HAS_BEFORE_INPUT_SUPPORT ||
isPlainTextOnlyPaste(event.nativeEvent)
isPlainTextOnlyPaste(event.nativeEvent) ||
IS_SAFARI
) {
event.preventDefault()
ReactEditor.insertData(editor, event.clipboardData)
Expand Down