Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slate-react): add top css to placeholder #5423

Merged
merged 1 commit into from
May 14, 2023

Conversation

horacioh
Copy link
Contributor

Description
Placeholder position in Safari 16.4 is not correct. this PR aims to fix that. I also checked that in other versions of Safari there's no regression.

Issue
Fixes: #5386

Example
Before:
image

After:
image

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: 9239ba6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 042bca1 into ianstormtaylor:main May 14, 2023
@github-actions github-actions bot mentioned this pull request May 14, 2023
@horacioh horacioh deleted the fix/placeholder-safari-16 branch May 18, 2023 01:21
@Arkellys
Copy link

Isn't this change too specific to Slate docs? It breaks my placeholders.

image

@jasontlouro
Copy link

image

Breaks ours as well, completely ignores padding on the editor.

@jasontlouro
Copy link

Sounds like a job for...

image

😅

@heyitsaamir
Copy link

heyitsaamir commented Jun 1, 2023

+1. Can we revert this? It's leading to a worse experience for most cases (i.e. atleast on chrome, it breaks like others have mentioned, even if it works on safari)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholders not placed correctly on Safari 16.4
5 participants