Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop a leftover useRef() call #5510

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

e1himself
Copy link
Contributor

@e1himself e1himself commented Sep 14, 2023

Description

The ref was initialized with useRef() and updated in an effect but was never read.

Issue

Fixes: ---

Example

Nothing changes in the behavior.

Context

It was first introduced in #4819 but then the usage of this ref was removed with #4874. So it remained unused since then.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

It was first introduced in ianstormtaylor#4819
but then the usage of this ref was removed with ianstormtaylor#4874

So the ref remained unused since then.
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: 85b8b0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 13c7d27 into ianstormtaylor:main Sep 18, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
@e1himself e1himself deleted the fix/leftover-use-ref branch December 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants