Fix crash when deleting paragraph ending \n
in Firefox
#5549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a Firefox browser quirk, the DOM selection sometimes includes the additional
\n
added whenisTrailing
is true inTextString
. This results in an invalid focus point, causing a crash during delete operations.Issue
Fixes: #5273
Example
Before:
before.mp4
After:
after.mp4
Context
It's possible that the logic for the check I added might not be perfect. However, I'm 99% sure that any new bugs it introduces will be harder to reproduce accidentally than the bug it fixes.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)