Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatically inserts an empty text node after inserting an image #5598

Merged

Conversation

CaptainCrouton89
Copy link
Contributor

Description
Automatically adds an empty text node after inserting an image in the example code for using images in Slate.

Issue
Fixes #5597

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: f162dee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @CaptainCrouton89

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaptainCrouton89 see the quick suggested changes by Prettier. Thanks.

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested changes from prettier

site/examples/images.tsx Outdated Show resolved Hide resolved
site/examples/images.tsx Outdated Show resolved Hide resolved
site/examples/images.tsx Outdated Show resolved Hide resolved
@dylans dylans merged commit f0f4772 into ianstormtaylor:main Feb 9, 2024
10 of 11 checks passed
@CaptainCrouton89
Copy link
Contributor Author

Thanks for fixing that! Glad it's making it in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add text after creating an image in official Slate image example
2 participants