-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add shouldMergeNodesRemovePrevNode #5621
Merged
dylans
merged 2 commits into
ianstormtaylor:main
from
felixfeng33:chore/shouldMergeNodesRemovePrevNode
Apr 1, 2024
Merged
chore: add shouldMergeNodesRemovePrevNode #5621
dylans
merged 2 commits into
ianstormtaylor:main
from
felixfeng33:chore/shouldMergeNodesRemovePrevNode
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2575e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
12joan
suggested changes
Mar 28, 2024
12joan
suggested changes
Mar 28, 2024
felixfeng33
force-pushed
the
chore/shouldMergeNodesRemovePrevNode
branch
from
March 28, 2024 23:56
94e6f94
to
e2575e6
Compare
12joan
approved these changes
Mar 29, 2024
Merged
This was referenced Aug 12, 2024
z2devil
pushed a commit
to z2devil/slate
that referenced
this pull request
Dec 6, 2024
* chore: add shouldMergeNodesRemovePrevNode * fix: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see https://slate-js.slack.com/archives/CC58ZGGU9/p1711614468642409
Issue
Fixes: (link to issue)
Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)
Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)