Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add shouldMergeNodesRemovePrevNode #5621

Merged

Conversation

felixfeng33
Copy link
Contributor

Description
see https://slate-js.slack.com/archives/CC58ZGGU9/p1711614468642409

Issue
Fixes: (link to issue)

Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)

Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)

Checks

  • [x ] The new code matches the existing patterns and styles.
  • [x ] The tests pass with yarn test.
  • [x ] The linter passes with yarn lint. (Fix errors with yarn fix.)
  • [x ] The relevant examples still work. (Run examples with yarn start.)
  • [x ] You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Mar 28, 2024

🦋 Changeset detected

Latest commit: e2575e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/slate/src/editor/index.ts Outdated Show resolved Hide resolved
packages/slate/src/transforms-node/merge-nodes.ts Outdated Show resolved Hide resolved
@felixfeng33 felixfeng33 requested a review from 12joan March 28, 2024 12:33
.changeset/early-mayflies-grow.md Outdated Show resolved Hide resolved
@felixfeng33 felixfeng33 force-pushed the chore/shouldMergeNodesRemovePrevNode branch from 94e6f94 to e2575e6 Compare March 28, 2024 23:56
@felixfeng33 felixfeng33 requested a review from 12joan March 28, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants