fix: marks at the start of the selection #5725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the selection is at the end of the previous node, using Editor.marks retrieves the marks of the previous node. In this case, calling Editor.addMark does not override the previous node, thus causing the states to be out of sync.
Issue
Fixes: #5724
Example
Before the fix:
When fixed:
Context
Thanks to the fix in #5580 , we can easily address this issue. By swapping the positions of anchor and focus according to Range.isBackward, we can then proceed with the original correction logic.
Additionally, since Editor.nodes calls Range.edges to recalibrate the order of anchor and focus, it won't affect the original Editor.marks logic.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)