Ignore selectionchange
events originating from <input>
and <textarea>
elements
#5795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Chrome,
selectionchange
events can fire when<input>
and<textarea>
elements are appended to the DOM, causingeditor.selection
to be overwritten in some circumstances. This PR addresses this issue by ignoringselectionchange
events originating from these elements.Issue
Fixes: #5791
Example
Before:
before.mp4
After:
after.mp4
Context
Although Chrome's behaviour is apparently compliant with the spec, other browsers do not behave this way, and the spec may at some point be changed to match other browsers' behaviour. See the Chromium issue for more information.
I'm fairly sure that ignoring
selectionchange
events from<input>
and<textarea>
elements will not cause other issues, since actual text selections in these elements do not affecteditor.selection
. However, if this PR causes a regression, feel free to revert it, since any bug it causes is likely to be more common than the one it fixes.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)