fix warning: dont call =~ on an Array, which is returning nil anyhow #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ def match_field | |||
|
|
|||
| def parse_hash(hash) | |||
| hash.inject({}) do |parsed, (key, val)| | |||
| if session && val =~ /^#{capture_model}$/ | |||
| if session && !val.is_a?(Array) && val =~ /^#{capture_model}$/ | |||
There was a problem hiding this comment.
@mathieujobin I'm seeing this error also for Hash. Could this be changed to only perform the regex check if val.is_a?(String)?
There was a problem hiding this comment.
@ejennings-mdsol yes it can, I simply preferred to make as little behavioral changes as possible.
If you think it's safe to do it on String only. we can update it.
I am also tempted to add the exclusion on Hash as well, so that if val is something else, we would know
There was a problem hiding this comment.
You are correct... I made this change, will be released as v0.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.