Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trash deprecated ruby/rails version, add support for cucumber 8 #96

Merged
merged 3 commits into from
Apr 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 6 additions & 80 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,88 +15,14 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby:
- '3.1'
- '3.0'
- 2.7
- 2.6
- 2.5
gemfile:
# Cucumber 3.2+
- Gemfile-rails.4.2.x
- Gemfile-rails.5.0.x
- Gemfile-rails.5.1.x
- Gemfile-rails.5.2.x
- Gemfile-rails.6.0.x-cukes-3
- Gemfile-rails.6.1.x-cukes-3
# Cucumber 4.1+
- Gemfile-rails.5.2.x-cukes-4
- Gemfile-rails.6.0.x-cukes-4
# Cucumber 5.3+
- Gemfile-rails.5.2.x-cukes-5
- Gemfile-rails.6.0.x-cukes-5
- Gemfile-rails.6.1.x-cukes-5
# Cucumber 6
- Gemfile-rails.6.0.x-cukes-6
- Gemfile-rails.6.1.x-cukes-6
- Gemfile-rails.7.0.x-cukes-6
# Cucumber 7
- Gemfile-rails.6.0.x-cukes-7
- Gemfile-rails.6.1.x-cukes-7
- Gemfile-rails.7.0.x-cukes-7
# Edge
- Gemfile-rails.edge
exclude:
# Rails edge is now 7.x and requires ruby 2.7
- gemfile: Gemfile-rails.edge
ruby: 2.6
- gemfile: Gemfile-rails.edge
ruby: 2.5
- gemfile: Gemfile-rails.7.0.x-cukes-7
ruby: 2.6
- gemfile: Gemfile-rails.7.0.x-cukes-7
ruby: 2.5
- gemfile: Gemfile-rails.7.0.x-cukes-6
ruby: 2.6
- gemfile: Gemfile-rails.7.0.x-cukes-6
ruby: 2.5
- gemfile: Gemfile-rails.4.2.x
ruby: 2.7
- gemfile: Gemfile-rails.4.2.x
ruby: '3.0'
- gemfile: Gemfile-rails.4.2.x
ruby: '3.1'
- gemfile: Gemfile-rails.5.0.x
ruby: '3.1'
- gemfile: Gemfile-rails.5.1.x
ruby: '3.1'
- gemfile: Gemfile-rails.5.2.x
ruby: '3.1'
- gemfile: Gemfile-rails.6.0.x-cukes-3
ruby: '3.1'
- gemfile: Gemfile-rails.6.1.x-cukes-3
ruby: '3.1'
- gemfile: Gemfile-rails.5.2.x-cukes-4
ruby: '3.1'
- gemfile: Gemfile-rails.6.0.x-cukes-4
ruby: '3.1'
- gemfile: Gemfile-rails.5.2.x-cukes-5
ruby: '3.1'
- gemfile: Gemfile-rails.6.0.x-cukes-5
ruby: '3.1'
- gemfile: Gemfile-rails.6.1.x-cukes-5
ruby: '3.1'
- gemfile: Gemfile-rails.6.0.x-cukes-6
ruby: '3.1'
- gemfile: Gemfile-rails.6.1.x-cukes-6
ruby: '3.1'
- gemfile: Gemfile-rails.6.0.x-cukes-7
ruby: '3.1'
- gemfile: Gemfile-rails.6.1.x-cukes-7
ruby: '3.1'
rails: ["7.0", "6.1", "6.0"]
ruby: ["3.2.2", "3.1.4", "3.0.6", "2.7.8"]
cucumber: ["8.0", "7.0", "6.0", "5.0", "4.0", "3.0"]

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}
RUBY_VERSION: ${{ matrix.ruby }}
RAILS_VERSION: ${{ matrix.rails }}
CUKES_VERSION: ${{ matrix.cucumber }}
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
Expand Down
9 changes: 5 additions & 4 deletions gemfiles/Gemfile-rails.5.2.x-cukes-5 → Gemfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
source "https://rubygems.org"

# Bundler 1.x default to insecure http:// for github: shortcut
git_source(:github){ |repo_name| "https://github.com/#{repo_name}.git" }

gemspec :path => ".."
gemspec :path => "."

gem "rails", "~> 5.2.0"
gem "cucumber", "~> 5.0"
# use ENV vars, with default value as fallback for local setup
ruby (ENV['RUBY_VERSION'] || '3.2.2')
gem "rails", "~> #{ENV['RAILS_VERSION'] || '7.0'}.0"
gem "cucumber", "~> #{ENV['CUKES_VERSION'] || '7.0'}"
gem "cucumber-rails"
gem 'fabrication', github: 'mathieujobin/fabrication', ref: '923cf6fcefd0566b1d6be7bd2f685b89388f4800'
7 changes: 7 additions & 0 deletions History.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
== 0.8.0
* Added support for Cucumber 8.x
* Removed support for Rails 4.2 -> 5.2
* Removed support for Ruby 2.0 -> 2.6
* Clean up Gemfiles, testing Ruby 2.7 -> 3.2 and Rails 6.0 -> 7.0
* Cucumber 3.x -> 8.x remain supported.

== 0.7.2
* Eliminate noisy warning: =~ called on anything but String objects.

Expand Down
13 changes: 0 additions & 13 deletions gemfiles/Gemfile-rails.4.2.x

This file was deleted.

216 changes: 0 additions & 216 deletions gemfiles/Gemfile-rails.4.2.x.lock

This file was deleted.

12 changes: 0 additions & 12 deletions gemfiles/Gemfile-rails.5.0.x

This file was deleted.

10 changes: 0 additions & 10 deletions gemfiles/Gemfile-rails.5.1.x

This file was deleted.

11 changes: 0 additions & 11 deletions gemfiles/Gemfile-rails.5.2.x

This file was deleted.

Loading