fix: support CRLF line endings in comments #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TOML v1.0.0 spec explicitly states that newlines are marked by either LF or CRLF sequences, and that comments are to be ended by newlines. Thus, it follows that the control characters used for newline sequences are in accordance to the specification. These changes introduce support for CRLF line endings in comments by peeking if a CR is followed by a LF during comment parsing. If that's the case, no unexpected control character error is thrown. I've tested these changes to work fine with both LF and CRLF files. I also tested spec conformance by introducing a stray CR in the middle of a comment line, which still causes a control character error to be thrown, as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TOML v1.0.0 spec explicitly states that newlines are marked by either LF or CRLF sequences, and that comments are to be ended by newlines. Thus, it follows that the control characters used for newline sequences are in accordance to the specification.
These changes introduce support for CRLF line endings in comments by peeking if a CR is followed by a LF during comment parsing. If that's the case, no unexpected control character error is thrown. I've tested these changes to work fine with both LF and CRLF files. I also tested spec conformance by introducing a stray CR in the middle of a comment line, which still causes a control character error to be thrown, as expected.
Fixes: #33