use grep to filter out pointer events #279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my computer moving the cursor with the touchpad or scrolling would generated quite high (~10%) cpu usage from fusuma. It seems like this is due to the large amount of output generated by
libinput debug-events
. Removing all of thePOINTER_MOTION
andPOINTER_SCROLL_FINGER
events with grep fixed that for me (I guess grep is much more cpu-efficient than ruby...).I already wrote this code for use on my computer so I wasn't sure it was necessary to open an issue before creating this PR
Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running
bundle exec rspec
andbundle exec rubocop
.This doesn't introduce any rubocop complaints but rspec needs to be updated (I don't know ruby and don't really have an idea how to do it)
Update code documentation if necessary. Not necessary (I think)