Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call block with plugin_default_context #311

Merged

Conversation

iberianpig
Copy link
Owner

I introduced plugin_defaults as an internal function for setting default values for fusuma plugins, but the search logic contained a bug.
fusuma-plugin-sendkey uses plugin_defaults to set the default value of device_names. ref: iberianpig/fusuma-plugin-sendkey#33

---
plugin:
executors:
 sendkey_executor:
   device_name: keyboard|Keyboard|KEYBOARD

Before the fix, the block was not evaluated when the context was a complete match, so the plugin could not get the default value.

- find_context in plugin_defaults context was not evaluated when it was a complete match
- Therefore, the value could not be obtained in the block
@iberianpig iberianpig changed the title fix: plugin_default_context call block with complete_match context at last fix: call block with plugin_default_context Sep 25, 2023
@iberianpig iberianpig marked this pull request as ready for review September 25, 2023 16:19
@iberianpig iberianpig merged commit 04a943d into master Sep 25, 2023
4 checks passed
@iberianpig iberianpig deleted the fix/skipped_calling_block_with_plugin_defaults_context branch September 25, 2023 16:21
@iberianpig iberianpig added the bug label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant