IBX-7329: Applied code review suggestions

ibexa · Dec 13, 2023 · 49143bf · 49143bf
1 parent d24682c
commit 49143bf
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 29 deletions.
diff --git a/src/bundle/Resources/public/scss/fieldType/edit/_base-field.scss b/src/bundle/Resources/public/scss/fieldType/edit/_base-field.scss
@@ -101,16 +101,13 @@
             &__distraction-free-mode {
                 margin: auto 0 0;
                 align-self: baseline;
+                width: 20%;
             }
 
             &__label-wrapper {
                 width: 80%;
             }
 
-            &__distraction-free-mode {
-                width: 20%;
-            }
-
             &__data {
                 width: 100%;
             }

diff --git a/src/bundle/Resources/translations/ibexa_admin_ui.en.xliff b/src/bundle/Resources/translations/ibexa_admin_ui.en.xliff
@@ -11,6 +11,31 @@
         <target state="new">Missing or invalid CSRF token</target>
         <note>key: asset.upload.invalid_csrf</note>
       </trans-unit>
+      <trans-unit id="68a1a5ea4fa56098f5eae44460514a09ea8f8509" resname="distraction_free_mode.disable.label">
+        <source>Exit distraction free mode</source>
+        <target state="new">Exit distraction free mode</target>
+        <note>key: distraction_free_mode.disable.label</note>
+      </trans-unit>
+      <trans-unit id="3b73a0132e7934156fcf413f3af229612d8eca9c" resname="distraction_free_mode.disable.tooltip">
+        <source>Exit distraction free mode.</source>
+        <target state="new">Exit distraction free mode.</target>
+        <note>key: distraction_free_mode.disable.tooltip</note>
+      </trans-unit>
+      <trans-unit id="d4de5a4ec1a58e845b16ca57b75b6b7585b2c5af" resname="distraction_free_mode.disable_hint">
+        <source>To exit distraction free mode, click the %icon% or press Esc.</source>
+        <target state="new">To exit distraction free mode, click the %icon% or press Esc.</target>
+        <note>key: distraction_free_mode.disable_hint</note>
+      </trans-unit>
+      <trans-unit id="2b32ded42b66d42abbe117ec91d128e2c85bd20d" resname="distraction_free_mode.enable.label">
+        <source>Distraction free mode</source>
+        <target state="new">Distraction free mode</target>
+        <note>key: distraction_free_mode.enable.label</note>
+      </trans-unit>
+      <trans-unit id="8145d8a19ad7bb79048f2a1391153c8f45b2d14f" resname="distraction_free_mode.enable.tooltip">
+        <source>Enter distraction free mode. It shows only rich text editor toolbar and focuses your attention on editing text.</source>
+        <target state="new">Enter distraction free mode. It shows only rich text editor toolbar and focuses your attention on editing text.</target>
+        <note>key: distraction_free_mode.enable.tooltip</note>
+      </trans-unit>
       <trans-unit id="d899cb1dbb25a42ea34f296bf7bef9821df66b72" resname="edit_translation.edit.title">
         <source>Edit</source>
         <target state="new">Edit</target>

diff --git a/src/bundle/Resources/translations/messages.en.xliff b/src/bundle/Resources/translations/messages.en.xliff
@@ -261,31 +261,6 @@
         <target state="new">No results found</target>
         <note>key: dashboard.charts.no_results</note>
       </trans-unit>
-      <trans-unit id="68a1a5ea4fa56098f5eae44460514a09ea8f8509" resname="distraction_free_mode.disable.label">
-        <source>Exit Distraction free mode</source>
-        <target state="new">Exit Distraction free mode</target>
-        <note>key: distraction_free_mode.disable.label</note>
-      </trans-unit>
-      <trans-unit id="3b73a0132e7934156fcf413f3af229612d8eca9c" resname="distraction_free_mode.disable.tooltip">
-        <source>Exit Distraction free mode.</source>
-        <target state="new">Exit Distraction free mode.</target>
-        <note>key: distraction_free_mode.disable.tooltip</note>
-      </trans-unit>
-      <trans-unit id="d4de5a4ec1a58e845b16ca57b75b6b7585b2c5af" resname="distraction_free_mode.disable_hint">
-        <source>To exit distraction free mode, click the %icon% or press Esc.</source>
-        <target state="new">To exit distraction free mode, click the %icon% or press Esc.</target>
-        <note>key: distraction_free_mode.disable_hint</note>
-      </trans-unit>
-      <trans-unit id="2b32ded42b66d42abbe117ec91d128e2c85bd20d" resname="distraction_free_mode.enable.label">
-        <source>Distraction free mode</source>
-        <target state="new">Distraction free mode</target>
-        <note>key: distraction_free_mode.enable.label</note>
-      </trans-unit>
-      <trans-unit id="8145d8a19ad7bb79048f2a1391153c8f45b2d14f" resname="distraction_free_mode.enable.tooltip">
-        <source>Enter distraction free mode. It shows only rich text editor toolbar and focuses your attention on editing text.</source>
-        <target state="new">Enter distraction free mode. It shows only rich text editor toolbar and focuses your attention on editing text.</target>
-        <note>key: distraction_free_mode.enable.tooltip</note>
-      </trans-unit>
       <trans-unit id="272e650f8667b4f4fcb7032b85b98ef4a9974f0f" resname="dropdown.search">
         <source>Search...</source>
         <target state="new">Search...</target>

diff --git a/src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig b/src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig
@@ -508,6 +508,8 @@
 {%- endblock %}
 
 {%- block distraction_free_mode -%}
+    {% trans_default_domain 'ibexa_admin_ui' %}
+
     {%- set title_icon -%}
         <svg class="ibexa-icon ibexa-icon--small">
             <use xlink:href="{{ ibexa_icon_path('un-focus') }}"></use>