Fixed incorrect type-hinting of Form DTO BookmarkRemoveData

ibexa · Dec 27, 2024 · 8d8bd8c · 8d8bd8c
1 parent 33f9c0e
commit 8d8bd8c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/bundle/Controller/BookmarkController.php b/src/bundle/Controller/BookmarkController.php
@@ -80,7 +80,7 @@ public function listAction(Request $request): Response
         );
 
         $removeBookmarkForm = $this->formFactory->removeBookmark(
-            new BookmarkRemoveData($this->getChoices($pagerfanta->getCurrentPageResults()))
+            new BookmarkRemoveData($this->getChoices(iterator_to_array($pagerfanta->getCurrentPageResults())))
         );
 
         return $this->render(
@@ -125,9 +125,9 @@ public function removeAction(Request $request): Response
     }
 
     /**
-     * @param array $bookmarks
+     * @param array<\Ibexa\AdminUi\UI\Value\Location\Bookmark> $bookmarks
      *
-     * @return array
+     * @return array<int, false>
      */
     private function getChoices(array $bookmarks): array
     {

diff --git a/src/lib/Form/Data/Bookmark/BookmarkRemoveData.php b/src/lib/Form/Data/Bookmark/BookmarkRemoveData.php
@@ -13,29 +13,29 @@
 class BookmarkRemoveData
 {
     /**
-     * @var array
+     * @var array<int, false>
      */
     #[Assert\NotBlank]
-    public $bookmarks;
+    public array $bookmarks;
 
     /**
-     * @param array $bookmarks
+     * @param array<int, false> $bookmarks
      */
     public function __construct(array $bookmarks = [])
     {
         $this->bookmarks = $bookmarks;
     }
 
     /**
-     * @return array
+     * @return array<int, false>
      */
     public function getBookmarks(): array
     {
         return $this->bookmarks;
     }
 
     /**
-     * @param array $bookmarks
+     * @param array<int, false> $bookmarks
      */
     public function setBookmarks(array $bookmarks): void
     {