-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7246: Burger menu duplicated for tabs without children #1015
Conversation
This code should work like this: When we are on any tab with children and we choose other tab with children:
How code works:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take a look at browser tests on CI. Looks like something is wrong after this change. Also, rebase is required to eliminate PHPStan errors.
src/bundle/Resources/views/themes/admin/ui/menu/main_2nd_level.html.twig
Outdated
Show resolved
Hide resolved
0be2ea3
to
90c9ac9
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
CI error is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.6 commerce.
Burger menu duplicated for tabs without children
Checklist:
$ composer fix-cs
)