Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7246: Burger menu duplicated for tabs without children #1015

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

Gengar-i
Copy link
Contributor

Question Answer
Tickets IBX-7246
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Burger menu duplicated for tabs without children

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@Gengar-i
Copy link
Contributor Author

Gengar-i commented Nov 29, 2023

This code should work like this:

When we are on any tab with children and we choose other tab with children:

  • We can see both tabs or all element from both tabs

How code works:

  • If we are on tab with children and click any tab with children:

    • We can see only tab we choose.
  • If we are on tab without children and click any tab with children:

    • We can see both. (maybe url is the same that is why this code works, its not the same for tab childrens)

@Gengar-i Gengar-i marked this pull request as draft November 29, 2023 16:23
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take a look at browser tests on CI. Looks like something is wrong after this change. Also, rebase is required to eliminate PHPStan errors.

@Gengar-i Gengar-i requested a review from mikadamczyk November 30, 2023 11:39
@Gengar-i Gengar-i marked this pull request as ready for review November 30, 2023 11:39
@Gengar-i Gengar-i requested a review from mikadamczyk November 30, 2023 12:00
@Gengar-i Gengar-i force-pushed the ibx-7246-duplicated-burger-menu branch from 0be2ea3 to 90c9ac9 Compare December 6, 2023 10:06
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomaszszopinski
Copy link
Contributor

CI error is unrelated.

Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@dew326 dew326 merged commit c3b733b into main Dec 6, 2023
22 of 23 checks passed
@dew326 dew326 deleted the ibx-7246-duplicated-burger-menu branch December 6, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants