Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7273: No svg for empty filter dropdown #1023

Merged
merged 1 commit into from
Dec 4, 2023
Merged

IBX-7273: No svg for empty filter dropdown #1023

merged 1 commit into from
Dec 4, 2023

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Dec 1, 2023 •
edited by adamwojs
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7273
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Screenshot

image

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

lucasOsti
lucasOsti requested changes Dec 1, 2023
View reviewed changes
src/bundle/Resources/public/scss/_dropdown.scss Outdated
@@ -214,6 +214,10 @@
&__items-list-filter-empty {
padding: calculateRem(16px);
text-align: center;

img {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we try avoid use selector by tag

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GrabowskiM GrabowskiM requested a review from Gengar-i December 1, 2023 14:18
@adamwojs adamwojs merged commit ec6a41c into main Dec 4, 2023
23 checks passed
@adamwojs adamwojs deleted the IBX-7273-no-image branch December 4, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tischsoic tischsoic tischsoic approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@GrabowskiM @adamwojs @tischsoic @lucasOsti @Gengar-i @mikadamczyk @Nattfarinn @ciastektk @dew326 @ViniTou