Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7302: No left sidebar when no anchor menu items #1037

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Dec 8, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7302
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes/no
License GPL-2.0

Related PRs:

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@tischsoic tischsoic force-pushed the IBX-7302-remove-left-sidebar-when-no-anchor-items branch from 6f896ce to a03ef0a Compare December 15, 2023 10:01
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sidebar is still visible in language form
Screenshot 2023-12-15 at 11 32 49
  1. Line in the form changes length https://recordit.co/AkbzpiUdBW

  2. Meta tab is not displayed in the form

Screenshot 2023-12-15 at 13 34 32 Screenshot 2023-12-15 at 13 37 12

@tischsoic
Copy link
Contributor Author

@katarzynazawada, reported problems should be fixed now except for 2nd which is not related to this PR (this bug also occurs on the main/Nightly).

I also added additional PRs:

@Gengar-i Gengar-i self-requested a review December 21, 2023 14:45
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 440078b into main Jan 3, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7302-remove-left-sidebar-when-no-anchor-items branch January 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants