Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7059: Added align-items for icon-wrapper #1050

Merged
merged 2 commits into from
Dec 15, 2023
Merged

IBX-7059: Added align-items for icon-wrapper #1050

merged 2 commits into from
Dec 15, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets IBX-7059
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

The issue also occurs on 4.5, so I created a PR from 4.5

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Dec 12, 2023
@mateuszdebinski mateuszdebinski requested a review from a team December 12, 2023 14:19
@mateuszdebinski mateuszdebinski self-assigned this Dec 12, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GrabowskiM GrabowskiM requested a review from a team December 13, 2023 12:58
barbaragr
barbaragr approved these changes Dec 14, 2023
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(i)ncredible ;)

@dew326 dew326 merged commit e9b42f5 into 4.5 Dec 15, 2023
16 checks passed
@dew326 dew326 deleted the IBX-7059_crop_notification_icon_align branch December 15, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mateuszdebinski @GrabowskiM @dew326 @barbaragr @mikadamczyk @Nattfarinn @ciastektk @ViniTou