Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7356: [Sub-items] - disable Columns settings in Grid view #1055

Merged
merged 7 commits into from
Dec 18, 2023
Merged

IBX-7356: [Sub-items] - disable Columns settings in Grid view #1055

merged 7 commits into from
Dec 18, 2023

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Dec 13, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7356
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes/no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Dec 13, 2023
@konradoboza konradoboza self-assigned this Dec 13, 2023
@konradoboza konradoboza force-pushed the ibx-7356-hide-columns-panel-in-grid-view branch from b87f24a to f058353 Compare December 13, 2023 14:30
@konradoboza konradoboza marked this pull request as ready for review December 13, 2023 14:30
@konradoboza konradoboza requested a review from dew326 December 15, 2023 07:44
@konradoboza konradoboza force-pushed the ibx-7356-hide-columns-panel-in-grid-view branch from 45a7fcc to 4ef6658 Compare December 15, 2023 08:09
@barbaragr barbaragr self-assigned this Dec 15, 2023
@konradoboza
Copy link
Contributor Author

Reworked proposed solution to disable mentioned button instead of hiding it. There is still some on-hover styles applied in the disabled state, but Jakub promised to help me with this issue.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

barbaragr
barbaragr approved these changes Dec 18, 2023
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@barbaragr barbaragr removed their assignment Dec 18, 2023
@webhdx webhdx merged commit 3603253 into main Dec 18, 2023
22 checks passed
@webhdx webhdx deleted the ibx-7356-hide-columns-panel-in-grid-view branch December 18, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@konradoboza @adamwojs @GrabowskiM @tischsoic @dew326 @barbaragr @Gengar-i @webhdx