IBX-7525: UDW as npm package #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
changed the title
lucasOsti
force-pushed
the
IBX-6398-STAGE-2-UDW-as-npm-package
branch
from
f5655e8 to
84192a0
Compare
lucasOsti
force-pushed
the
IBX-6398-STAGE-2-UDW-as-npm-package
branch
from
ceea777 to
9528601
Compare
GrabowskiM
requested changes
Jan 3, 2024
| if (props.extraClasses) { | ||
| className = `${className} ${props.extraClasses}`; | ||
| } | ||
| const includedIcon = props.useIncludedIcon || window.origin !== instanceUrl; |
There was a problem hiding this comment.
isIncludedIcon/hasIncludedIcon would probably be better name :)
Comment on lines
73
to
77
| return ( | ||
| <> | ||
| <IconComponent className={cssClass} /> | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Suggested change
| return ( | |
| <> | |
| <IconComponent className={cssClass} /> | |
| </> | |
| ); | |
| return <IconComponent className={cssClass} />; |
| import { getIconPath } from '@ibexa-admin-ui/src/bundle/Resources/public/js/scripts/helpers/icon.helper'; | ||
|
|
||
| const UrlIcon = (props) => { | ||
| const linkHref = props.customPath ? props.customPath : getIconPath(props.name); |
There was a problem hiding this comment.
Suggested change
| const linkHref = props.customPath ? props.customPath : getIconPath(props.name); | |
| const linkHref = props.customPath ?? getIconPath(props.name); |
Gengar-i
approved these changes
Jan 11, 2024
lucasOsti
changed the title
lucasOsti
force-pushed
the
IBX-6398-STAGE-2-UDW-as-npm-package
branch
from
181068e to
245bc8d
Compare
tischsoic
approved these changes
Jan 16, 2024
lucasOsti
force-pushed
the
IBX-6398-STAGE-2-UDW-as-npm-package
branch
from
245bc8d to
1ebad2d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)