Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6679: Disabled delete action in field definition form when translating content type #1080

Merged
merged 1 commit into from
Jan 10, 2024
Merged

IBX-6679: Disabled delete action in field definition form when translating content type #1080

merged 1 commit into from
Jan 10, 2024

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Dec 25, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6679
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs changed the base branch from main to 4.5 December 25, 2023 19:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk requested a review from a team January 3, 2024 07:31
@konradoboza konradoboza requested a review from a team January 3, 2024 07:32
@adamwojs adamwojs mentioned this pull request Jan 5, 2024
Merged
2 tasks
@micszo micszo self-assigned this Jan 10, 2024
@micszo micszo mentioned this pull request Jan 10, 2024
Closed
micszo
micszo approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ibexa Commerce 4.5.x-dev.

@micszo micszo removed their assignment Jan 10, 2024
@adamwojs adamwojs merged commit 81323c4 into 4.5 Jan 10, 2024
23 of 24 checks passed
@adamwojs adamwojs deleted the ibx_6679 branch January 10, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@dew326 dew326 dew326 approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@adamwojs @mikadamczyk @dew326 @micszo @konradoboza @Nattfarinn @ciastektk @webhdx @ViniTou