Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7182: Implemented autoopen on init page for extra actions #1085

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Gengar-i
Copy link
Contributor

Question Answer
Tickets IBX-7182
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Implemented autoopen on init page for extra actions

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@@ -56,15 +56,26 @@
focusElement.focus();
}
};
const init = (dataset) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this function more self-explanatory name, but truth be told, I have no idea how, autoOpenSidebar? not exactly there, as it's conditional auto-open 🤔

@Gengar-i Gengar-i requested a review from GrabowskiM January 3, 2024 13:19
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 90e1f66 into main Jan 11, 2024
22 checks passed
@dew326 dew326 deleted the ibx-7182-create-product-redirect-to-tab branch January 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants