Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7411: Implemented data labels for doughnut charts #1093

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Jan 4, 2024

Question Answer
Tickets IBX-7411
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0
Required ibexa/admin-ui-assets#20

Implemented datalabels for doughnut charts
Implemented new empty chart img

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs changed the title IBX-7411: Implemented datalabels for doughnut charts IBX-7411: Implemented data labels for doughnut charts Jan 5, 2024
@micszo micszo self-assigned this Jan 17, 2024
@Gengar-i Gengar-i force-pushed the ibx-7411-chart-js-datalabels branch from 300e533 to fdf791d Compare January 17, 2024 11:16
@Gengar-i Gengar-i force-pushed the ibx-7411-chart-js-datalabels branch from fdf791d to 1472287 Compare January 18, 2024 09:34
@micszo
Copy link
Contributor

micszo commented Jan 18, 2024

Current status:

  • Block configuration: Categories limit -> Number of categories* [NOK]
  • Missing % labels on chart [OK, but https://recordit.co/O0IrgcA3LQ occurs]
  • Broken labels in tooltips [OK]

@Gengar-i Gengar-i force-pushed the ibx-7411-chart-js-datalabels branch from 1472287 to 391cb19 Compare January 19, 2024 13:03
@micszo
Copy link
Contributor

micszo commented Jan 19, 2024

After retest:

  1. OK
  2. https://issues.ibexa.co/browse/IBX-7574

@Gengar-i Gengar-i force-pushed the ibx-7411-chart-js-datalabels branch from 391cb19 to e14b7e3 Compare January 23, 2024 09:25
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo removed their assignment Jan 23, 2024
@adamwojs adamwojs merged commit 55d71a2 into main Jan 23, 2024
22 checks passed
@adamwojs adamwojs deleted the ibx-7411-chart-js-datalabels branch January 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants