Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7489: Fix user settings password change Discard button link #1095

Merged
merged 2 commits into from
Jan 5, 2024
Merged

IBX-7489: Fix user settings password change Discard button link #1095

merged 2 commits into from
Jan 5, 2024

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7489
Bug fix? yes/no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@tischsoic tischsoic requested a review from a team January 5, 2024 09:55
@tischsoic tischsoic self-assigned this Jan 5, 2024
@Steveb-p Steveb-p requested a review from a team January 5, 2024 10:02
konradoboza
konradoboza approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from failing code style job.

@konradoboza konradoboza requested a review from a team January 5, 2024 10:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@barbaragr barbaragr self-assigned this Jan 5, 2024
barbaragr
barbaragr approved these changes Jan 5, 2024
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikadamczyk mikadamczyk merged commit fd6f3b4 into main Jan 5, 2024
22 checks passed
@mikadamczyk mikadamczyk deleted the IBX-7489-fix-user-settings-password-change-discard-btn-link branch January 5, 2024 14:08
@tischsoic tischsoic added the Doc needed The changes require some documentation label Jan 5, 2024
@julitafalcondusza julitafalcondusza removed the Doc needed The changes require some documentation label Apr 25, 2024
@julitafalcondusza julitafalcondusza mentioned this pull request Apr 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@barbaragr barbaragr barbaragr approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@tischsoic tischsoic

@ViniTou ViniTou

@barbaragr barbaragr

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tischsoic @adamwojs @mikadamczyk @Steveb-p @barbaragr @konradoboza @Nattfarinn @ciastektk @ViniTou @julitafalcondusza