Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1689: Change all ez- classes/IDs and eZ variables in frontend part #111

Merged
merged 8 commits into from
Dec 21, 2021

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Dec 13, 2021

Question Answer
JIRA issue IBX-1689
Type improvement
Target Ibexa version v4.0
BC breaks yes

Changed all eZ/ez- frontend classes/variables to ibexa

Related PRs:

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@@ -190,7 +190,7 @@
};

if (isAutosaveEnabled()) {
const AUTOSAVE_SUBMIT_BUTTON_NAME = 'ezplatform_content_forms_content_edit[autosave]';
const AUTOSAVE_SUBMIT_BUTTON_NAME = 'ibexa_content_forms_content_edit[autosave]';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure?

@@ -63,7 +63,7 @@

showSuccessNotification(
Translator.trans(
/* @Desc("The image has been published and can now be reused") */ 'ezimageasset.create.message.success',
/* @Desc("The image has been published and can now be reused") */ 'ibexaimageasset.create.message.success',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay

@@ -77,7 +77,7 @@
*/
onAssetCreateFailure(error) {
const message = Translator.trans(
/* @Desc("Error while creating Image Asset: %error%") */ 'ezimageasset.create.message.error',
/* @Desc("Error while creating Image Asset: %error%") */ 'ibexaimageasset.create.message.error',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@@ -161,7 +161,7 @@

const udwContainer = doc.getElementById('react-udw');
const config = JSON.parse(event.currentTarget.dataset.udwConfig);
const title = Translator.trans(/*@Desc("Select Image Asset")*/ 'ezimageasset.title', {}, 'universal_discovery_widget');
const title = Translator.trans(/*@Desc("Select Image Asset")*/ 'ibexaimageasset.title', {}, 'universal_discovery_widget');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

$ez-pagination-margin: 0.25rem;
$ez-pagination-page-link-radius: 50%;
$ez-pagination-border-radius: 0.3rem;
$ibexa-admin-transition: $ibexa-admin-transition;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change.

@@ -1,5 +1,5 @@
// TODO: remove when commerce is redesigned
.ez-filters {
.ibexa-filters {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is time to remove it ;)


.ibexa-instant-filter,
.ez-instant-filter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is time to remove it

// TODO: should be remove when ez-table--list is redesigned
.ez-table {
// TODO: should be remove when ibexa-table--list is redesigned
.ibexa-table {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to remove

@GrabowskiM GrabowskiM requested a review from dew326 December 16, 2021 10:30
@GrabowskiM GrabowskiM force-pushed the IBX-1689-rename-ez-to-ibexa-front branch from 61569fa to 7e37ce6 Compare December 17, 2021 11:41
@dew326 dew326 merged commit a4bdc57 into main Dec 21, 2021
@dew326 dew326 deleted the IBX-1689-rename-ez-to-ibexa-front branch December 21, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants