Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7304: Exposed pathString property in load-subtree REST response #1129

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jan 25, 2024

Question Answer
JIRA issue IBX-7304
Required by ibexa/site-context#31, ibexa/taxonomy#265, ibexa/tree-builder#128
Type bug
Target version v4.6
BC breaks no
Doc needed no

To resolve https://github.com/ibexa/site-context/pull/31#issuecomment-1906253762 we need to expose Location pathString in load-subtree REST response, so we can disable preview if it matches one of the Site Context excluded paths.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly.
  • Asked for a review.

@alongosz alongosz requested a review from a team January 26, 2024 09:31
@alongosz alongosz added Bug Something isn't working Ready for review labels Jan 26, 2024
@adamwojs adamwojs requested a review from a team January 27, 2024 09:14
@alongosz alongosz force-pushed the ibx-7304-expose-path-string-in-load-subtree branch from e7c5333 to c339688 Compare February 1, 2024 12:59
@alongosz alongosz force-pushed the ibx-7304-expose-path-string-in-load-subtree branch from c339688 to e771bf2 Compare February 7, 2024 12:56
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit e859d4d into main Feb 7, 2024
23 checks passed
@alongosz alongosz deleted the ibx-7304-expose-path-string-in-load-subtree branch February 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants