Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7621: Remove X for extra actions sidebar and focus for search by content type input #1133

Merged
merged 1 commit into from
Feb 12, 2024
Merged

IBX-7621: Remove X for extra actions sidebar and focus for search by content type input #1133

merged 1 commit into from
Feb 12, 2024

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Jan 29, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7621
Type bug
Target version v4.6
BC breaks no
Doc needed no

  1. UDW
    Screenshot from 2024-01-31 15-08-26

  2. Content

Screenshot from 2024-01-31 15-08-42

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@lucasOsti lucasOsti force-pushed the IBX-7621-Create-content-in-media-input-bug branch 2 times, most recently from d3d1ec0 to 10c3e86 Compare January 29, 2024 12:27
@lucasOsti lucasOsti added Bug Something isn't working Ready for review labels Jan 29, 2024
@lucasOsti lucasOsti force-pushed the IBX-7621-Create-content-in-media-input-bug branch from 10c3e86 to 7ef1558 Compare January 29, 2024 12:29
@lucasOsti lucasOsti force-pushed the IBX-7621-Create-content-in-media-input-bug branch from da4bfc1 to 2d4750d Compare January 31, 2024 14:07
@barbaragr barbaragr self-assigned this Feb 9, 2024
@lucasOsti lucasOsti force-pushed the IBX-7621-Create-content-in-media-input-bug branch from 2d4750d to 1974deb Compare February 9, 2024 10:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

barbaragr
barbaragr requested changes Feb 12, 2024
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Focus mode + full screen mode on, search in sidebar menu is still focused.
Screenshot 2024-02-12 at 09 09 19

@dew326 dew326 merged commit 7327ac9 into main Feb 12, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7621-Create-content-in-media-input-bug branch February 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@barbaragr barbaragr

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lucasOsti @adamwojs @GrabowskiM @dew326 @barbaragr @Gengar-i @mikadamczyk @Nattfarinn @ciastektk @ViniTou