Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7644: Customizable dashboard, Page Builder - Select / switching layout #1136

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7644
Type bug
Target Ibexa version v4.6
BC breaks no

Checklist:

  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@barbaragr barbaragr self-assigned this Feb 5, 2024
@GrabowskiM GrabowskiM force-pushed the IBX-7644-pb-switch-layout branch from 8268b9c to bd30f45 Compare February 6, 2024 09:00
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked state (click with mouse button but don't release) should looks like hover:
Screenshot 2024-02-06 at 14 04 41

Screenshot 2024-02-06 at 14 05 10

@GrabowskiM
Copy link
Contributor Author

Clicked state (click with mouse button but don't release) should looks like hover: Screenshot 2024-02-06 at 14 04 41

Screenshot 2024-02-06 at 14 05 10

There is already fix for it in this PR https://github.com/ibexa/page-builder/pull/326/files that changes box-shadow opacity from 0.75 to 0.2

@GrabowskiM GrabowskiM force-pushed the IBX-7644-pb-switch-layout branch from bd30f45 to a366adf Compare February 12, 2024 08:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 82aa599 into main Feb 12, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7644-pb-switch-layout branch February 12, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants