Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7656: Changed quick action to work with fragment #1138

Merged
merged 1 commit into from
Jan 31, 2024
Merged

IBX-7656: Changed quick action to work with fragment #1138

merged 1 commit into from
Jan 31, 2024

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jan 30, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7656
Type bug
Target version v4.6
BC breaks no
Doc needed no

Quick action now will work with hashes instead of query parameters. Used by https://github.com/ibexa/dashboard/pull/100

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@mikadamczyk mikadamczyk added the Bug Something isn't working label Jan 30, 2024
@mikadamczyk mikadamczyk self-assigned this Jan 30, 2024
@mikadamczyk mikadamczyk changed the title IBX-7182: Changed quick action to work with fragment IBX-7656: Changed quick action to work with fragment Jan 30, 2024
@katarzynazawada katarzynazawada mentioned this pull request Jan 31, 2024
Closed
@mikadamczyk mikadamczyk force-pushed the IBX-7182-quick-actions-product branch from c825852 to d90d702 Compare January 31, 2024 10:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk merged commit f471b17 into main Jan 31, 2024
22 checks passed
@mikadamczyk mikadamczyk deleted the IBX-7182-quick-actions-product branch January 31, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@konradoboza konradoboza konradoboza approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@adamwojs adamwojs adamwojs approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@webhdx webhdx Awaiting requested review from webhdx

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@mikadamczyk mikadamczyk

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikadamczyk @adamwojs @tischsoic @dew326 @konradoboza @katarzynazawada @Gengar-i